Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Belarus holidays: add ru & th l10n, 2024-2025 substituted holidays #2192

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Dec 25, 2024

Proposed change

Implements the following changes for Belarus holidays:

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b7718d8) to head (5d94ea0).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        11725     11755   +30     
  Branches      1687      1697   +10     
=========================================
+ Hits         11725     11755   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Prateekshit73
Copy link
Contributor

Hello @PPsyrius,

I hope this message finds you well. I apologize for the interruption and for bringing up a different topic, but I am currently facing an issue with the testing portion of the holidays project, specifically related to the Afghanistan holidays implementation.

While running the tests, I encountered an assertion error indicating a mismatch between the expected and actual supported languages for Afghanistan. The test expects only ['fa'], but the implementation supports both ['fa', 'ps']. I want to ensure that I am approaching this correctly and would greatly appreciate any guidance on how to resolve this discrepancy.

I attempted to create a new discussion related to this issue, but unfortunately, I was unable to perform that action.

If there are any specific steps or considerations I should keep in mind while addressing this issue, I would be very grateful for your insights.

Thank you for your time and assistance!

@PPsyrius
Copy link
Collaborator Author

Hello @PPsyrius,

I hope this message finds you well. I apologize for the interruption and for bringing up a different topic, but I am currently facing an issue with the testing portion of the holidays project, specifically related to the Afghanistan holidays implementation.

While running the tests, I encountered an assertion error indicating a mismatch between the expected and actual supported languages for Afghanistan. The test expects only ['fa'], but the implementation supports both ['fa', 'ps']. I want to ensure that I am approaching this correctly and would greatly appreciate any guidance on how to resolve this discrepancy.

I attempted to create a new discussion related to this issue, but unfortunately, I was unable to perform that action.

If there are any specific steps or considerations I should keep in mind while addressing this issue, I would be very grateful for your insights.

Thank you for your time and assistance!

No worries, have you added the supported_languages entry for your own holidays\countries\afghanistan.py file yet?

Not to be confused with default_language here.

@Prateekshit73
Copy link
Contributor

Hello @PPsyrius,
I hope this message finds you well. I apologize for the interruption and for bringing up a different topic, but I am currently facing an issue with the testing portion of the holidays project, specifically related to the Afghanistan holidays implementation.
While running the tests, I encountered an assertion error indicating a mismatch between the expected and actual supported languages for Afghanistan. The test expects only ['fa'], but the implementation supports both ['fa', 'ps']. I want to ensure that I am approaching this correctly and would greatly appreciate any guidance on how to resolve this discrepancy.
I attempted to create a new discussion related to this issue, but unfortunately, I was unable to perform that action.
If there are any specific steps or considerations I should keep in mind while addressing this issue, I would be very grateful for your insights.
Thank you for your time and assistance!

No worries, have you added the supported_languages entry for your own holidays\countries\afghanistan.py file yet?

Not to be confused with default_language here.

Yes Sir

country = "AF"
default_language = "fa"
supported_languages = ("fa", "ps")

@arkid15r
Copy link
Collaborator

Hello @PPsyrius,
I hope this message finds you well. I apologize for the interruption and for bringing up a different topic, but I am currently facing an issue with the testing portion of the holidays project, specifically related to the Afghanistan holidays implementation.
While running the tests, I encountered an assertion error indicating a mismatch between the expected and actual supported languages for Afghanistan. The test expects only ['fa'], but the implementation supports both ['fa', 'ps']. I want to ensure that I am approaching this correctly and would greatly appreciate any guidance on how to resolve this discrepancy.
I attempted to create a new discussion related to this issue, but unfortunately, I was unable to perform that action.
If there are any specific steps or considerations I should keep in mind while addressing this issue, I would be very grateful for your insights.
Thank you for your time and assistance!

No worries, have you added the supported_languages entry for your own holidays\countries\afghanistan.py file yet?
Not to be confused with default_language here.

Yes Sir

country = "AF"
default_language = "fa"
supported_languages = ("fa", "ps")

@Prateekshit73 you can use #1144 for discussion.
Also make sure that README.rst file describes the supported languages correctly.

holidays/countries/belarus.py Outdated Show resolved Hide resolved
holidays/countries/belarus.py Outdated Show resolved Hide resolved
holidays/countries/belarus.py Outdated Show resolved Hide resolved
holidays/countries/belarus.py Outdated Show resolved Hide resolved
holidays/locale/ru/LC_MESSAGES/BY.po Outdated Show resolved Hide resolved
tests/countries/test_belarus.py Outdated Show resolved Hide resolved
tests/countries/test_belarus.py Outdated Show resolved Hide resolved
tests/countries/test_belarus.py Outdated Show resolved Hide resolved
tests/countries/test_belarus.py Outdated Show resolved Hide resolved
holidays/countries/belarus.py Outdated Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from KJhellico December 26, 2024 12:53
KJhellico
KJhellico previously approved these changes Dec 26, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

just want to make sure the Easter Monday is implemented correctly:

holidays/countries/belarus.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KJhellico @PPsyrius thanks for taking care of that!

LGTM

@arkid15r arkid15r enabled auto-merge (squash) December 27, 2024 18:00
@arkid15r arkid15r merged commit 301185b into vacanza:dev Dec 27, 2024
32 checks passed
@PPsyrius PPsyrius deleted the belarus_th_l10n branch December 29, 2024 23:46
@arkid15r arkid15r mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants