-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Belarus holidays: add ru & th l10n, 2024-2025 substituted holidays #2192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2192 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 195 195
Lines 11725 11755 +30
Branches 1687 1697 +10
=========================================
+ Hits 11725 11755 +30 ☔ View full report in Codecov by Sentry. |
Hello @PPsyrius, I hope this message finds you well. I apologize for the interruption and for bringing up a different topic, but I am currently facing an issue with the testing portion of the holidays project, specifically related to the Afghanistan holidays implementation. While running the tests, I encountered an assertion error indicating a mismatch between the expected and actual supported languages for Afghanistan. The test expects only ['fa'], but the implementation supports both ['fa', 'ps']. I want to ensure that I am approaching this correctly and would greatly appreciate any guidance on how to resolve this discrepancy. I attempted to create a new discussion related to this issue, but unfortunately, I was unable to perform that action. If there are any specific steps or considerations I should keep in mind while addressing this issue, I would be very grateful for your insights. Thank you for your time and assistance! |
No worries, have you added the Not to be confused with |
Yes Sir
|
@Prateekshit73 you can use #1144 for discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
just want to make sure the Easter Monday is implemented correctly:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KJhellico @PPsyrius thanks for taking care of that!
LGTM
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
ff92abe
to
5d94ea0
Compare
Quality Gate passedIssues Measures |
Proposed change
Implements the following changes for Belarus holidays:
ru
) and Thai (th
) localization - the former based on the official Belarus government source.WORKDAY
category support for those considered as National/Country-wide/Religious holidays but don't belong in the current Non-Working day status.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green