Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align financial markets MIC codes with ISO 10383 #2158

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Align financial markets MIC codes with ISO 10383 (NYSE → XNYS, ECB → XECB).
Add consistency test for financial markets table in README.rst.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e969609) to head (d28eb1c).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       194           
  Lines        11557     11559    +2     
  Branches      1641      1641           
=========================================
+ Hits         11557     11559    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkid15r
arkid15r previously approved these changes Dec 5, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/test_docs.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
@arkid15r
Copy link
Collaborator

arkid15r commented Dec 5, 2024

Just for the record -- I've already implemented this change as a part of our v1 standardization goal here. Thanks for adding it to v0 too!

Co-authored-by: Arkadii Yakovets <[email protected]>
Copy link

sonarqubecloud bot commented Dec 6, 2024

@arkid15r arkid15r enabled auto-merge December 6, 2024 16:17
@arkid15r arkid15r added this pull request to the merge queue Dec 6, 2024
Merged via the queue into vacanza:dev with commit 5f37ecc Dec 6, 2024
30 checks passed
@KJhellico KJhellico deleted the upd-markets branch December 6, 2024 21:21
@KJhellico KJhellico mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants