-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Albania holidays, add l10n support #2104
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2104 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 192
Lines 11563 11577 +14
Branches 1739 1741 +2
=========================================
+ Hits 11563 11577 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇦🇱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A couple of optional suggestions:
Proposed change
Update Albania holidays, add l10n support (en_US, sq, uk).
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green