-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Germany holidays: add East German Uprising Day 2028 in Berlin #2092
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2092 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 191 191
Lines 11537 11537
Branches 1738 1738
=======================================
Hits 11535 11535
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: ~Jhellico <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this!
…acanza#2092) Co-authored-by: ~Jhellico <[email protected]>
Proposed change
Adds the
75th anniversary of the East German uprising of 1953
for Berlin, Germany in 2028. English localization is partially based on a DW article and Ukranian one could use a review here @KJhellico .Resolves #2089 .
Type of change
holidays
functionality in general)Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally