Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cambodia and Laos test cases #2086

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

As proposed by @KJhellico in #2081 :

Now that 2058 is no longer a special year for Thai calendar, can we replace it with a more standard 2050? Or rather, 2049, because most countries use range(N, 2050).

I think the checks for 2158 are more related to Thai calendar tests than to Thailand itself. And since tests\calendars\test_thai.py already contains checks for this year, they are redundant here.

This PR aims to address these issues.

  • Switching test case end date back to 2050 like other typical country-level implementations.
  • Moving all relevant Thai calendar-related testing to Thai calendar test cases, except for Pchum Ben and Bon Om Tok since we'll still need to check for its 2-day and 3-day celebration variants.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b2e6837) to head (35597d9).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2086   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines        11547     11545    -2     
  Branches      1744      1742    -2     
=========================================
- Hits         11547     11545    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KJhellico KJhellico changed the title Refractors Cambodia and Laos test cases Refactor Cambodia and Laos test cases Oct 29, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arkid15r arkid15r added this pull request to the merge queue Oct 29, 2024
Merged via the queue into vacanza:dev with commit abcffe3 Oct 29, 2024
29 checks passed
@PPsyrius PPsyrius deleted the kh_la_standard_test branch October 29, 2024 18:35
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants