-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Cambodia and Laos test cases #2086
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2086 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 191 191
Lines 11547 11545 -2
Branches 1744 1742 -2
=========================================
- Hits 11547 11545 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed change
As proposed by @KJhellico in #2081 :
This PR aims to address these issues.
Pchum Ben
andBon Om Tok
since we'll still need to check for its 2-day and 3-day celebration variants.Type of change
holidays
functionality in general)Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally