-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Germany holidays: add th
localization, deprecated non-standard ISO code, add subdivision aliases
#1979
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1979 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 188
Lines 11403 11407 +4
Branches 1789 1790 +1
=========================================
+ Hits 11403 11407 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇩🇪 LGTM
…rd ISO code, add subdivision aliases (vacanza#1979) Co-authored-by: Arkadii Yakovets <[email protected]>
Proposed change
This PR includes 3 changes for Germany 🇩🇪 holidays:
BYP
code. Catholic municipalities in Bavaria will instead need to include theCATHOLIC
category to mimic the previously implemented behavior.EN
,MI
, HASC) #1952 by adding "Bayern (Katholisch)
" as a subregion too? I'm open to all suggestions here.th
localization. (Checked with https://bangkok.diplo.de/th-th/botschaft/oeffnungszeiten/1670002 )Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally