-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Lao New Year holidays #1962
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1962 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 188
Lines 11419 11422 +3
Branches 1795 1799 +4
=========================================
+ Hits 11419 11422 +3 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: ~Jhellico <[email protected]>
Co-Authored-By: ~Jhellico <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @PPsyrius!
Proposed change
Refractor existing
Lao New Year
holidays logic to better match the official calendars, move the in-lieu observance start from 2018 to 2012 to better match the actual situation.Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally