Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1991-2022 Russian substituted holidays #1957

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Aug 28, 2024

Proposed change

Add 1991-2022 Russian substituted holidays, 1991-2025 Russian observed holidays.

Resolves #432 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1a6a764) to head (8d4808e).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1957   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11421     11422    +1     
  Branches      1794      1794           
=========================================
+ Hits         11421     11422    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius
Copy link
Collaborator Author

I don't think there's a way to reduce "new code duplication" for our test suite here without changing how def test_special_holidays(self) is coded, so ignore sonarcloud results for now.

@KJhellico
Copy link
Collaborator

@PPsyrius, thank you for this addition. Although I like researching substituted holidays in different countries, I prefer not to make changes to RU holidays myself for personal reasons.

If you are interested, you can look for more complete list here.

@PPsyrius PPsyrius changed the title Add 1993-2022 Russian substituted holidays Add 1991-2022 Russian substituted holidays Aug 28, 2024
@PPsyrius
Copy link
Collaborator Author

@KJhellico Understandable, in any case I've expanded and updated Russian substituted holidays down to 1991, as well as adding in-lieu observance for 1991-2025 from the Wikipedia source you posted above. 🙏

Copy link

@arkid15r arkid15r enabled auto-merge August 30, 2024 16:00
@arkid15r arkid15r added this pull request to the merge queue Aug 30, 2024
Merged via the queue into vacanza:dev with commit 0359e5a Aug 30, 2024
31 checks passed
@PPsyrius PPsyrius deleted the rus_1993-2022_substituted_holidays branch August 31, 2024 09:26
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Russian holidays for 2021 are missing some reschedulings
3 participants