-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jordan holidays #1746
Add Jordan holidays #1746
Conversation
Pull Request Test Coverage Report for Build 8541663992Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @firaskafri,
thanks for adding another country support!
Please see some minor comments to address before merging this PR:
@abh31000, could you review this when you get a chance? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more correct. And it's unified across all the other AR locales
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: abh31000 <[email protected]>
Co-authored-by: abh31000 <[email protected]>
Co-authored-by: abh31000 <[email protected]>
Co-authored-by: abh31000 <[email protected]>
Co-authored-by: abh31000 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@firaskafri, thank you for your contribution! A couple of fixes:
thank you @KJhellico , all fixed. Thanks! |
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: ~Jhellico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @firaskafri. Thanks for fixing all the comments! The PR looks very decent, I'm going to take another look today and merge it.
Here is an optional comment to address -- we've introduced AUTHORS file quite recently. Would you like to update it and add your name to the list?
@abh31000 thanks for reviewing the holiday names!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @firaskafri, I've updated the AUTHORS
file and merging this PR in.
Thanks a lot for adding another country holidays support!
Proposed change
Added Jordan (Country) to supported countries.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally