Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file header pre-commit check #1744

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Mar 29, 2024

Proposed change

I extended the file header inclusion to .po files and added a pre-commit check to keep it consistent. The AUTHORS file was also updated based on the removed authors comments from the .po files.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Extend file headers to .po files.
Update AUTHORS
@arkid15r arkid15r requested a review from KJhellico as a code owner March 29, 2024 17:02
@coveralls
Copy link

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 8483733589

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8472267167: 0.0%
Covered Lines: 10968
Relevant Lines: 10968

💛 - Coveralls

@arkid15r arkid15r enabled auto-merge March 29, 2024 17:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Mar 29, 2024
Merged via the queue into vacanza:dev with commit 0e8a8cf Mar 29, 2024
29 checks passed
@arkid15r arkid15r deleted the add-file-headers-check branch March 29, 2024 19:42
@KJhellico KJhellico mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants