-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package configuration: migrate to pyproject.toml #1466
Conversation
Use `find_namespace:` for `packages` option
With this parameter, builded tarball includes all scripts (previously l10n only), wheel includes docs, scripts and tests (that were not previously included). |
Yeah, that's not what we want. I migrated the configuration to pyproject.toml. I believe it's okay for sdist to have more src stuff included in scripts. The bdist contains required files only. |
Pull Request Test Coverage Report for Build 6225294800
💛 - Coveralls |
…idays into update-package-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need to test basic functionality of the built package. :)
I did some manual testing for my locally built package. That hadn't been enough as the clean env resulting package was different. Some automated testing would work better here. I added #1479 |
Proposed change
Resolves #1465
Migrate to pyproject.toml
Get rid of setup.cfg
Add package tests
Improve repr coverage
Type of change
Checklist
beta
branch of the repositorymake pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)