Add Algeria holidays

[abh31000]

Proposed change

Added Algeria holidays
Closes #1145
Stuck at 82% coverage. Can anyone tell me what I'm missing here?

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency upgrade (version update)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new python-holidays functionality in general)

Checklist

• I've followed the contributing guidelines
• This PR is filed against beta branch of the repository
• This PR doesn't contain any merge conflicts and has clean commit history
• The code style looks good: make pre-commit
• All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
• The related documentation has been added/updated (check off the box for free if no updates is required)

[KJhellico]

@abh31000, thank you for your contribution!

Seems your code based on master branch. You need to merge latest beta and add new line to holidays/registry.py for Algeria.

[coveralls]

Coverage: 99.729% (+0.001%) from 99.728% when pulling 2dc14a2 on abh31000:add-algeria into af76470 on dr-prodigy:beta.

[arkid15r]

Hi @abh31000,
thank you so much for implementing the Algeria holidays!

We're excited to see a new contributor! Also thanks a lot for addressing all the comments in such a timely manner.

I left a couple of minor comments below. Otherwise your code looks good!

P.S. as for the coverage issue you had with your first commit of this PR -- you can find out the uncovered lines by running make coverage (which is an alias for pytest --cov=. --cov-config=pyproject.toml --cov-report term-missing --dist loadscope --no-cov-on-fail --numprocesses auto)

[abh31000]

Hi @abh31000, thank you so much for implementing the Algeria holidays!

We're excited to see a new contributor! Also thanks a lot for addressing all the comments in such a timely manner.

I left a couple of minor comments below. Otherwise your code looks good!

P.S. as for the coverage issue you had with your first commit of this PR -- you can find out the uncovered lines by running make coverage (which is an alias for pytest --cov=. --cov-config=pyproject.toml --cov-report term-missing --dist loadscope --no-cov-on-fail --numprocesses auto)

You're welcome!
And now with this commit the test coverage is 100%.

[arkid15r]

🇩🇿 LGTM

[arkid15r]

Great work 👍, merged into beta!

Thank you!