refactor!: update avatar group to not use Polymer splices API #8145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Nov 14, 2024
| }, | ||
|
|
||
| /** @private */ | ||
| __items: { |
There was a problem hiding this comment.
The __items property was unused so I removed it.
web-padawan
force-pushed
the
refactor/avatar-group-items-change
branch
from
a6847ef to
d061382
Compare
web-padawan
commented
Nov 14, 2024
| @@ -231,17 +231,6 @@ class AvatarGroup extends ResizeMixin(OverlayClassMixin(ElementMixin(ThemableMix | |||
| value: () => [], | |||
| }, | |||
|
|
|||
| /** @private */ | |||
| __maxReached: { | |||
There was a problem hiding this comment.
This property was only used in one observer so I decided to inline it there, so that we only have one observer for updating overflow avatar instead of two different ones.
web-padawan
force-pushed
the
refactor/avatar-group-items-change
branch
from
8467944 to
f459ecb
Compare
|
tomivirkki
approved these changes
Nov 15, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed usage of
.splice()API fromvaadin-avatar-groupand removedcalculateSplices()usage.From now one, mutating
itemsproperty is no longer supported, instead it needs to be re-assigned.Marked as a behavior altering change because of that (but Flow counterpart shouldn't be affected).
Also updated observers syntax which is a pre-requisite for creating LitElement based version.
Type of change