fix: handle tooltip controller closing state properly #8131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Nov 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
web-padawan
added a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
This was referenced Nov 12, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are two findings that I discovered while working on #8129
close()is called twice e.g. on targetmouseleaveand then parentmouseover, the second call overwrites the__closeTimeoutreference so one of the timeouts is not cleared properly on reopening and tooltip unexpectedly closes,__closeTimeoutbut the tooltip is not removed from theclosingset - so before reopening, it is immediately closed by the logic that is supposed to flush other closing tooltips.This unfortunately can't be easily reproduced with default tooltips so I had to add a test that checks the controller logic.
IMO this is fine since the controller API +
manualmode is what we use invaadin-menu-barso we need to test it.Type of change