Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset charts series objects when chart is detached (#8115) (CP: 23.5) #8123

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@web-padawan
Copy link
Member

For some reason series array is empty which causes tests to fail. I'll investigate this.

@DiegoCardoso
Copy link
Contributor

DiegoCardoso commented Nov 8, 2024

For some reason series array is empty which causes tests to fail. I'll investigate this.

On the other CP I made, I had to add await nextFrame() to some tests because awaiting for chart-load were not enough

Copy link

sonarqubecloud bot commented Nov 8, 2024

@web-padawan web-padawan merged commit b337683 into 23.5 Nov 8, 2024
10 checks passed
@web-padawan web-padawan deleted the cherry-pick-8115-to-23.5-1731075315674 branch November 8, 2024 14:36
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 23.5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants