-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-open context-menu on closing contextmenu event #7484
Conversation
2ec2a8a
to
12dd118
Compare
64cbd24
to
6e8bd8a
Compare
6e8bd8a
to
a210da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The only question I have is whether this can be considered a breaking behavioral change since it required two right clicks before opening a new context menu.
That's a valid point. The new behavior is aligned with how native context menus work in general (in Finder etc) so it might also be expected by users. To be on the safe side, we could at least skip cherry-picking this to earlier minors (and only target 24.5). @rolfsmeds @yuriy-fix wdyt? |
|
We discussed this internally and agreed to merge this to 24.5 as a minor behavioral breaking change:
|
This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version. |
Description
Dispatch a new
contextmenu
event over the target in case the context-menu gets closed by acontextmenu
event. This enables opening a new context menu without closing the previous one first.Kapture.2024-06-11.at.13.38.34.mp4
Fixes #1135
Type of change
Bugfix