Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: observe target move on the page and update position #7427

Merged
merged 3 commits into from
May 20, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7424

Based on https://github.com/samthor/viz-observer (not the latest beta version but the implementation from Floating UI).

Type of change

  • Feature

@web-padawan web-padawan requested review from vursen and tomivirkki May 20, 2024 07:00
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan removed the request for review from tomivirkki May 20, 2024 08:22
@web-padawan web-padawan merged commit fb1b726 into main May 20, 2024
9 checks passed
@web-padawan web-padawan deleted the feat/position-target-observe-move branch May 20, 2024 08:22
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[popover] Position not updated when target moves on the screen (e.g. in resizable dialog)
3 participants