fix: consider a value matching selected item label a known value #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Jan 18, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
commented
Jan 18, 2022
Comment on lines
-98
to
+104
| await aTimeout(0); | ||
| await nextFrame(); | ||
|
|
||
| comboBox.value = comboBox.items[50]; | ||
| comboBox.close(); | ||
|
|
||
| comboBox.open(); | ||
| await aTimeout(0); | ||
| await nextFrame(); |
There was a problem hiding this comment.
This test was failing on master also for some reason. Changed the timings in the test to make it pass.
|
|
||
| // Try to find an item whose label matches the input value. A matching item is searched from | ||
| // the filteredItems array (if available) and the selectedItem (if available). | ||
| const itemMatchingByLabel = [...(this.filteredItems || []), this.selectedItem].find((item) => { |
There was a problem hiding this comment.
Cleaned up the logic a bit, but the main change here is that matching items are no longer searched only from the filteredItems array (which gets cleared by comboBoxConnector, producing the original bug) but also from selectedItem.
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
web-padawan
pushed a commit
that referenced
this pull request
Jan 18, 2022
…) (#3304) Co-authored-by: Tomi Virkki <[email protected]>
|
This ticket/PR has been released with platform 23.0.0.alpha3 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of vaadin/flow-components#2524
This change fixes the main issue in vaadin/flow-components#2524:
The "custom-item-set" event was dispatched even when the value matched the label of
comboBox.selectedItem.There's still another issue related to vaadin/flow-components#2524 (the dropdown doesn't populate on the first open after setting new items) but it will be fixed separately.