Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create default helper element lazily #2714

Merged
merged 11 commits into from
Oct 4, 2021
Merged

fix: create default helper element lazily #2714

merged 11 commits into from
Oct 4, 2021

Conversation

web-padawan
Copy link
Member

Description

Fixes #2382

This is an attempt to make the new behavior more or less aligned with that we used to have previously, i.e.

<slot name="helper">[[helperText]]</slot>

Notable changes:

  1. Setting helperText property (or attribute) only updates text content for the default helper, not for custom one.
  2. Text content from the custom helper is set to helperText property when it is inserted, but not updated later.
  3. When the custom helper is removed, the default one is restored. I had to use FlattenedNodesObserver for it.

Type of change

  • Bugfix

@web-padawan web-padawan added the a11y Accessibility issue label Oct 1, 2021
@web-padawan web-padawan requested a review from vursen October 1, 2021 17:55
vursen
vursen reviewed Oct 2, 2021
View reviewed changes
packages/field-base/src/field-mixin.js Outdated Show resolved Hide resolved
packages/field-base/src/field-mixin.js Outdated Show resolved Hide resolved
packages/field-base/src/field-mixin.js Outdated Show resolved Hide resolved
packages/field-base/src/field-mixin.js Outdated Show resolved Hide resolved
packages/radio-group/test/radio-group.test.js Outdated Show resolved Hide resolved
@web-padawan web-padawan requested a review from vursen October 2, 2021 16:48
vursen
vursen approved these changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added several more comments but they aren't very important and the PR looks good to me. Approved 👍

@web-padawan web-padawan requested a review from tomivirkki October 4, 2021 10:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit f45dc46 into master Oct 4, 2021
@web-padawan web-padawan deleted the fix/lazy-helper branch October 4, 2021 11:07
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

@RonaldZielaznicki RonaldZielaznicki mentioned this pull request Mar 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
a11y Accessibility issue prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[field-base] Do not override ID attribute on the custom helper
4 participants
@web-padawan @vaadin-bot @tomivirkki @vursen