Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set value on dataprovider callback #961

Merged
merged 14 commits into from
Nov 2, 2020
Merged

Fix: set value on dataprovider callback #961

merged 14 commits into from
Nov 2, 2020

Conversation

tulioag
Copy link
Contributor

@tulioag tulioag commented Oct 21, 2020

fixes: #900

yuriy-fix
yuriy-fix reviewed Oct 23, 2020
View reviewed changes
Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change checks for autoOpenDisabled and not applying the value if autoOpenDisabled is off.
I guess it should be changed to follow Diego's comment which specifies that it should behave regardless if autoOpenDisabled is on or off.

@tulioag
Copy link
Contributor Author

tulioag commented Oct 23, 2020

This change checks for autoOpenDisabled and not applying the value if autoOpenDisabled is off.
I guess it should be changed to follow Diego's comment which specifies that it should behave regardless if autoOpenDisabled is on or off.

The behaviour is consistent in both cases, since when data is received this._commitValue is called regardless of autoOpenDisabled's value. Added tests covering both cases.

@yuriy-fix
Copy link
Contributor

The behaviour is consistent in both cases, since when data is received this._commitValue is called regardless of autoOpenDisabled's value. Added tests covering both cases.

Have tried on the demo page. The valid value Finland is cleared right away on blurring the field if autoOpenDisabled is not applied.
aod

@tulioag tulioag requested a review from yuriy-fix October 27, 2020 14:53
@tulioag tulioag merged commit 46a688f into master Nov 2, 2020
@tulioag tulioag deleted the fix/900_Valid_item_is_not_selected_if_ComboBox_has_a_dataprovider_and_autoopendisabled branch November 2, 2020 08:55
@tulioag tulioag mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriy-fix yuriy-fix yuriy-fix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid item is not selected if ComboBox has a dataprovider and autoopendisabled
2 participants
@tulioag @yuriy-fix