Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Improve type mismatch and unresolved variable exception messages #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hesara
Copy link
Contributor

@hesara hesara commented Nov 17, 2016

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2016

CLA assistant check
All committers have signed the CLA.

@denis-anisimov
Copy link

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


src/main/java/com/vaadin/sass/internal/parser/LexicalUnitImpl.java, line 408 at r1 (raw file):

        if (getLexicalUnitType() == SCSS_VARIABLE) {
            // still unresolved
            throw new UnresolvedReferenceException("unresolved:" + this);

Is this message is informative enough ?
What's this.toString() here? Is it enough to understand its nature ? Is it variable or what ?


src/main/java/com/vaadin/sass/internal/parser/LexicalUnitImpl.java, line 412 at r1 (raw file):

        if (another.getLexicalUnitType() == SCSS_VARIABLE) {
            // still unresolved
            throw new UnresolvedReferenceException("unresolved:" + another);

Same here.


Comments from Reviewable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants