chore: update dependency to fix CVE-2023-6378 #4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies Report
|
vaadin-bot
approved these changes
Dec 4, 2023
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2023
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2023
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Zhe Sun <[email protected]>
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Zhe Sun <[email protected]>
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Zhe Sun <[email protected]>
knoobie
reviewed
Dec 4, 2023
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.4.12</version> |
There was a problem hiding this comment.
Note 1.4.14 was released because .12 and .13 had some bugs. Now that you manage this and it could take precendence over customer projects - it would probably good to use the latest version.
There was a problem hiding this comment.
oh, good to know that.. Thanks.
There was a problem hiding this comment.
Got another thing for you :) You should probably also add the other logback-* dependencies, otherwise you get a mismatch which is hard to debug: qos-ch/logback#744 (comment)
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Zhe Sun <[email protected]>
ZheSun88
added a commit
that referenced
this pull request
Dec 7, 2023
ZheSun88
added a commit
that referenced
this pull request
Dec 7, 2023
* chore : update dependency-check to use latest (#4731) * chore: update dependency-check to use 9.0.0 * Update sbom.yml * Update generateAndCheckSBOM.js --------- Co-authored-by: Manuel Carrasco Moñino <[email protected]> * update dependency to fix CVE-2023-6378 (#4759) * chore: update logback-classic to 1.4.14 [skip ci] (#4776) * chore: update logback-classic to 1.4.14 * Update pom.xml --------- Co-authored-by: Zhe Sun <[email protected]> Co-authored-by: Manuel Carrasco Moñino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.