feat(crud): support configured max page size #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 118 118
Lines 8192 8192
Branches 1259 1259
=======================================
Hits 7120 7120
Misses 1058 1058
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
requested changes
Feb 13, 2025
packages/java/endpoint/src/test/java/com/vaadin/hilla/crud/CrudRepositoryServiceJpaTest.java
Outdated
Show resolved
Hide resolved
packages/java/endpoint/src/main/java/com/vaadin/hilla/crud/ListRepositoryService.java
Outdated
Show resolved
Hide resolved
taefi
previously approved these changes
Feb 13, 2025
|
taefi
approved these changes
Feb 14, 2025
cromoteca
deleted the
feat/3203/AutoCrud-add-support-for-limiting-the-pageSize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ListRepositoryServiceand its subclasses, one can pass an arbitrary page size, potentially querying many lines. This is also true in Hilla, where the client side decides.This PR uses the existing
spring.data.rest.pageable.max-page-sizeproperty, if defined, and silently caps the maximum page size.Closes #3203.