Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify the jspecify version management in hilla #3216

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Feb 7, 2025

flow and hilla are using the same version of org.jspecify:jspecify. so use the transitive dependency from flow-server is simpler for maintenance

Copy link

sonarqubecloud bot commented Feb 7, 2025

@ZheSun88 ZheSun88 changed the title chore:remove jspecity dependency declaration chore: simplify the jspecify version management in hilla Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (881f960) to head (82fb21b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3216   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files         118      118           
  Lines        8191     8191           
  Branches     1256     1256           
=======================================
  Hits         7119     7119           
  Misses       1058     1058           
  Partials       14       14           
Flag Coverage Δ
unittests 86.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin Lodin merged commit 727f957 into main Feb 7, 2025
15 checks passed
@Lodin Lodin deleted the remove-jspecity-dependency-declaration branch February 7, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants