Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: avoid top level await (#2734) (CP: 24.4) #2735

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* test: add build target to module config

* test: replace top-level await with Promise API for i18n

---------

Co-authored-by: Anton Platonov <[email protected]>
Copy link

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.4@9240fe8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.4    #2735   +/-   ##
=======================================
  Coverage        ?   96.80%           
=======================================
  Files           ?       66           
  Lines           ?     4573           
  Branches        ?      664           
=======================================
  Hits            ?     4427           
  Misses          ?      142           
  Partials        ?        4           
Flag Coverage Δ
unittests 96.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha merged commit fea8637 into 24.4 Sep 17, 2024
15 checks passed
@platosha platosha deleted the cherry-pick-2734-to-24.4-1726561893162 branch September 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants