Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple fast navigate calls (#20446) (CP: 24.4) #20545

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix: multiple fast navigate calls

Fix issue where a slow connection
and fast `navigate` calls throws
exception due to faulty blocker
state change.

Fixes #20404

* Queue new navigations during ongoing navigation.

* fix blocker nav for basepath

Add test view for manual testing.
Test script doesn't fail on double click.

* Remove test class and selenium dependency.

---------

Co-authored-by: Mikhail Shabarov <[email protected]>
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) November 25, 2024 11:19
Copy link

Test Results

1 119 files  ±0  1 119 suites  ±0   1h 23m 39s ⏱️ + 2m 18s
7 093 tests ±0  7 044 ✅ ±0  49 💤 ±0  0 ❌ ±0 
7 445 runs   - 5  7 384 ✅  - 5  61 💤 ±0  0 ❌ ±0 

Results for commit 522305f. ± Comparison against base commit b4da9e8.

@vaadin-bot vaadin-bot merged commit e4fd795 into 24.4 Nov 25, 2024
23 of 25 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20446-to-24.4-1732532897675 branch November 25, 2024 11:24
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants