-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend WebPushMessage with the custom settings #20304
Conversation
30e4ad4
to
0fa84bf
Compare
To note: I'm working on figuring out how can we provide an API for adding action listener, else than asking to extend the service worker (sw.js). Also this needs some testing on mobile. UPD: I don't think we need to make a Java API for actions. Let's rely on the need of changing |
flow-webpush/src/main/java/com/vaadin/flow/server/webpush/WebPushMessage.java
Show resolved
Hide resolved
Tested with CRM tutorial in this branch https://github.com/vaadin/flow-crm-tutorial/tree/web-push-options. When "Open Dashboard" is clicked, the CRM Dashboard should be opened in a new window or focus an existing browser tab. |
flow-webpush/src/main/java/com/vaadin/flow/server/webpush/WebPushMessage.java
Outdated
Show resolved
Hide resolved
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Description
Adds an API to set custom options as described in https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification#parameters
Fixes #20285
Type of change
Checklist
Additional for
Feature
type of change