Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump slf4j.version from 1.7.36 to 2.0.0 #14409

Merged
merged 6 commits into from
Sep 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 22, 2022

Bumps slf4j.version from 1.7.36 to 2.0.0.
Updates slf4j-api from 1.7.36 to 2.0.0

Commits
  • 0614d46 prepare release 2.0.0
  • b1afcd0 javadoc edits
  • 20cd3ad start work on 2.0.0-SNAPSHOT
  • aeebb61 prepare release 2.0.0-beta1
  • 1068cd0 javadoc changes
  • 4e4e56a add CheckReturnValue annotation in org.slf4j.helpers
  • 0dcfa19 check for return value in some oggingEventBuilder methods
  • e7ca8d1 start work on 2.0.0-beta1-SNAPSHOPT
  • 2314de9 add setMessage and log method to the fluent API
  • 508a796 set version to 2.0.0-beta0
  • Additional commits viewable in compare view

Updates slf4j-simple from 1.7.36 to 2.0.0

Commits
  • 0614d46 prepare release 2.0.0
  • b1afcd0 javadoc edits
  • 20cd3ad start work on 2.0.0-SNAPSHOT
  • aeebb61 prepare release 2.0.0-beta1
  • 1068cd0 javadoc changes
  • 4e4e56a add CheckReturnValue annotation in org.slf4j.helpers
  • 0dcfa19 check for return value in some oggingEventBuilder methods
  • e7ca8d1 start work on 2.0.0-beta1-SNAPSHOPT
  • 2314de9 add setMessage and log method to the fluent API
  • 508a796 set version to 2.0.0-beta0
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `slf4j.version` from 1.7.36 to 2.0.0.

Updates `slf4j-api` from 1.7.36 to 2.0.0
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.36...v_2.0.0)

Updates `slf4j-simple` from 1.7.36 to 2.0.0
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.36...v_2.0.0)

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.slf4j:slf4j-simple
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added external dependency java Pull requests that update Java code labels Aug 22, 2022
taefi
taefi previously approved these changes Aug 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Unit Test Results

   922 files  ±0     922 suites  ±0   52m 57s ⏱️ - 2m 51s
6 032 tests ±0  5 979 ✔️ ±0  53 💤 ±0  0 ±0 
6 261 runs  ±0  6 201 ✔️ ±0  60 💤 ±0  0 ±0 

Results for commit 5c06ceb. ± Comparison against base commit 6ff6700.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mshabarov mshabarov merged commit 84704aa into master Sep 19, 2022
@mshabarov mshabarov deleted the dependabot/maven/slf4j.version-2.0.0 branch September 19, 2022 11:21
@knoobie
Copy link
Contributor

knoobie commented Sep 19, 2022

@mshabarov for what version is this planned? 24.0 or 23.3?

@mshabarov
Copy link
Contributor

@knoobie thanks for asking, this is for both 23.3 and 24. Even though it's a breaking change for those who uses SimpleLoggerFactory and rely on the slf4j version provided by Vaadin, we thought the package name change is trivial and clear, so we can include it to 23.3. Do you have any concerns agains that? Please share, I don't see a strong reason to include this update exactly into 23.3 .

@knoobie
Copy link
Contributor

knoobie commented Sep 21, 2022

@mshabarov I would be against an update into 23.3 :) that's where my question comes from - the Log4J Version that supports 2.0 was just recently released 3 days ago (2.19.0) and even Spring Boot 2.7 can't really support it because the default Implementation of SLF4J (Logback) in Version 1.2 is used. Log back 1.3/1.4 comes with full support for 2.0, but that can't be integrated into SB 2.7 because of the policy that no feature releases are included in a 2.x.y Bugfix Release and currently Boot doesn't plan to add support for it with reflection magic so that 1.2-1.4 could be used - instead Boot and Spring "plans" (at least it looks like it) that they wanna only update to 2.0 in their 6.0 and respective 3.0 release (the next milestone after the one coming today or tomorrow)

TL;DR: 23.3 shouldn't update - 24 sounds like a good fit with SB 3.0

@mshabarov
Copy link
Contributor

@knoobie excellent comment, thanks! I agree that better not upgrade it until V24. Proposed to be reverted.

@knoobie
Copy link
Contributor

knoobie commented Sep 21, 2022

Thanks for considering! Sorry for the mess with all the version numbers ;) Dependency Management is just a mess.. You can find all the information also more scattered e.g. in the SB issue about upgrading spring-projects/spring-boot#12649

mshabarov added a commit that referenced this pull request Sep 21, 2022
…14409)"

Reverted because 2.0 is not fully supported by Spring and might cause a breaking changes rather that package names.
mshabarov added a commit that referenced this pull request Sep 21, 2022
…14409)" (#14594)

Reverted because 2.0 is not fully supported by Spring and might cause a breaking changes rather that package names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency java Pull requests that update Java code +0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants