Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lumoImports not recognized in dev mode , when placed in a parent theme #19567

Closed
SonReimer opened this issue Jun 12, 2024 · 5 comments
Closed

lumoImports not recognized in dev mode , when placed in a parent theme #19567

SonReimer opened this issue Jun 12, 2024 · 5 comments
Assignees
@tltv
Labels
BFP Bugfix priority, also known as Warranty bug Impact: Low prerelease version for Vaadin 24.6.0 Released with Vaadin 24.4.15 Released with Vaadin 24.5.3 Released with Vaadin 24.6.0.alpha2 Severity: Minor theming

Comments

@SonReimer
Copy link

SonReimer commented Jun 12, 2024 •
edited
Loading

Description of the bug

Defining lumoImports in the theme.json of a parent theme inside the same project,
the styles defined in java by the LumoUtility are not applied.
This only happens in dev mode.

Expected behavior

It should not matter if the import is done in the project theme or it's parent.

Minimal reproducible example

lumoImports.zip

Versions

  • Vaadin / Flow version: At least 24.3.12 and 24.4.1
  • Java version: 17
  • OS version: Windows
  • Browser version (if applicable): Firefox
  • Application Server (if applicable): spring-boot(embedded tomact)
  • IDE (if applicable): Eclispe 23-03
@mshabarov
Copy link
Contributor

This change may help fix this issue, but I'd expect lumoImports to work even if they are added to the parent theme, documentation doesn't state any limitation about it.

@tepi tepi added the BFP Bugfix priority, also known as Warranty label Oct 16, 2024
@mshabarov mshabarov moved this from 🔎 Investigation to 🔖 High Priority (P1) in Vaadin Flow bugs & maintenance (Vaadin 10+) Oct 17, 2024
@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Oct 17, 2024
@mshabarov
Copy link
Contributor

The issue was triaged and currently added to the backlog priority queue for further investigation.

@tltv tltv self-assigned this Oct 23, 2024
@tltv tltv moved this from 🪵Product backlog to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Oct 23, 2024
tltv added a commit that referenced this issue Oct 23, 2024
@tltv
fix: import parent theme lumoImports in dev bundle mode
8dc67b1 
Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567
@tltv tltv mentioned this issue Oct 23, 2024
Merged
tltv added a commit that referenced this issue Oct 24, 2024
@tltv
fix: import parent theme lumoImports in dev bundle mode
7c05d67 
Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567
mshabarov pushed a commit that referenced this issue Oct 29, 2024
@tltv
fix: import parent theme lumoImports in dev bundle mode (#20325)
df499c6 
* fix: import parent theme lumoImports in dev bundle mode

Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567

* test: fix test

* test: fix test

* chore: catch IllegalArgumentException in CssBundler

Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
@github-project-automation github-project-automation bot moved this from ⚒️ In progress to Done in Vaadin Flow ongoing work (Vaadin 10+) Oct 29, 2024
@github-project-automation github-project-automation bot moved this from 🔖 High Priority (P1) to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Oct 29, 2024
vaadin-bot pushed a commit that referenced this issue Oct 29, 2024
@tltv @vaadin-bot
fix: import parent theme lumoImports in dev bundle mode (#20325)
fb87602 
* fix: import parent theme lumoImports in dev bundle mode

Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567

* test: fix test

* test: fix test

* chore: catch IllegalArgumentException in CssBundler

Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
vaadin-bot pushed a commit that referenced this issue Oct 29, 2024
@tltv @vaadin-bot
fix: import parent theme lumoImports in dev bundle mode (#20325)
dfe5fe4 
* fix: import parent theme lumoImports in dev bundle mode

Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567

* test: fix test

* test: fix test

* chore: catch IllegalArgumentException in CssBundler

Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
vaadin-bot added a commit that referenced this issue Oct 29, 2024
@vaadin-bot @tltv
fix: import parent theme lumoImports in dev bundle mode (#20325) (#20379
f76b212 
)

* fix: import parent theme lumoImports in dev bundle mode

Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567

* test: fix test

* test: fix test

* chore: catch IllegalArgumentException in CssBundler

Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.

Co-authored-by: Tomi Virtanen <[email protected]>
mshabarov pushed a commit that referenced this issue Oct 30, 2024
@vaadin-bot @tltv
fix: import parent theme lumoImports in dev bundle mode (#20325) (#20380
54e59d1 
)

* fix: import parent theme lumoImports in dev bundle mode

Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567

* test: fix test

* test: fix test

* chore: catch IllegalArgumentException in CssBundler

Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.

Co-authored-by: Tomi Virtanen <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.3.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tltv tltv

Labels
BFP Bugfix priority, also known as Warranty bug Impact: Low prerelease version for Vaadin 24.6.0 Released with Vaadin 24.4.15 Released with Vaadin 24.5.3 Released with Vaadin 24.6.0.alpha2 Severity: Minor theming
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tepi @tltv @mcollovati @vaadin-bot @SonReimer @mshabarov