Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support content elements in React adapter #19379

Closed
platosha opened this issue May 15, 2024 · 1 comment · Fixed by #19434
Closed

Support content elements in React adapter #19379

platosha opened this issue May 15, 2024 · 1 comment · Fixed by #19434
Labels
hilla Issues related to Hilla Released with Vaadin 24.5.0

Comments

@platosha
Copy link
Contributor

Add support for adding Flow components as children to ReactAdapterComponent.

Implementation idea:

  • add useContent(name: string) ReactAdapterElement hook, supports rendering a DOM placeholder in React
  • add the corresponding protected Element getContentElement(String name) Java ReactAdapterComponent method, that creates and returns the named container element.

Prototype: https://github.com/vaadin/flow-hilla-hybrid-example/tree/proto/flow-react-children

The first implementation could use two DOM wrapper elements, each with style "display: contents;".
@platosha platosha added the hilla Issues related to Hilla label May 15, 2024
@caalador caalador self-assigned this May 21, 2024
@mshabarov mshabarov moved this to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) May 21, 2024
caalador added a commit that referenced this issue May 23, 2024
@caalador
feat: Flow components as children for ReactAdapterComponent
08aa69e 
Add support for having Flow Components
as children in a ReactAdapoterComponent

Fixes #19379
@caalador caalador mentioned this issue May 23, 2024
Merged
caalador added a commit that referenced this issue Jun 4, 2024
@caalador
feat: Flow components as children for ReactAdapterComponent (#19434)
0747540 
Add support for having Flow Components
as children in a ReactAdapoterComponent

Fixes #19379
@github-project-automation github-project-automation bot moved this from ⚒️ In progress to Done in Vaadin Flow ongoing work (Vaadin 10+) Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Under consideration in Roadmap Sep 23, 2024
@mshabarov mshabarov moved this from Under consideration to September 2024 (24.5) in Roadmap Sep 23, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hilla Issues related to Hilla Released with Vaadin 24.5.0
Projects
Roadmap
Status: September 2024 (24.5) - Released
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Flow components as children for ReactAdapterComponent vaadin/flow
3 participants
@platosha @caalador @vaadin-bot