Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report Gantt chart usage #7057

Merged
merged 3 commits into from
Feb 12, 2025
Merged

feat: report Gantt chart usage #7057

merged 3 commits into from
Feb 12, 2025

Conversation

bwajtr
Copy link
Contributor

@bwajtr bwajtr commented Jan 22, 2025

Description

Guillermo requested to track usage of Gantt Charts separately from the general vaadin-chart usage.

This PR adds that tracking to the flow component. Used LitRenderer custom usage tracking as an example:

UsageStatistics.markAsUsed("flow-components/LitRenderer", null);

There is also tracking of all Vaadin custom elements implemented in the element-mixin.js, however I haven't found any custom tracking that would manipulate the window.Vaadin.registrations directly, therefore I do the tracking from Java.

Part of #4731

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@bwajtr bwajtr enabled auto-merge (squash) February 12, 2025 10:37
Copy link

@bwajtr bwajtr merged commit e0860f0 into main Feb 12, 2025
5 checks passed
@bwajtr bwajtr deleted the feat/report-gantt-chart-usage branch February 12, 2025 10:49
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha9 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants