Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add i18n error message support for TimePicker #6365

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jun 11, 2024

Description

The PR introduces TimePickerI18n with methods for setting error messages and updates the TimePicker's validation logic to show these error messages when validation fails.

Note

It's still possible to use the setErrorMessage method to configure a single static error message. This error message will be displayed for all constraints and will take priority over any i18n error messages that are also set. However, when more than one error message is needed, i18n should be used or manual validation mode should be enabled.

Part of #4618

Type of change

  • Feature

@vursen vursen marked this pull request as ready for review June 13, 2024 10:42
@vursen vursen requested review from DiegoCardoso and yuriy-fix June 13, 2024 10:58
@vursen vursen requested review from sissbruecker and DiegoCardoso and removed request for yuriy-fix and DiegoCardoso July 11, 2024 06:20
@vursen vursen force-pushed the feat/time-picker/error-messages branch from 31d5e7b to 21019e4 Compare July 11, 2024 11:40
@vursen vursen force-pushed the feat/time-picker/error-messages branch from 21019e4 to 3dfa921 Compare July 11, 2024 11:51
@vursen vursen changed the title feat!: support setting error messages with TimePickerI18n feat: support setting error messages with TimePickerI18n Jul 18, 2024
@vursen
Copy link
Contributor Author

vursen commented Jul 18, 2024

During our internal discussion, we discovered a way to keep error messages that are set with setErrorMessage. They now take priority over i18n error messages, which allows developers to continue using the old familiar method, setting a single error message for all constraints. I've updated the PR and also removed the breaking change mark.

@vursen vursen changed the title feat: support setting error messages with TimePickerI18n feat: add i18n error message support for TimePicker Jul 19, 2024
@vursen vursen requested review from DiegoCardoso and sissbruecker and removed request for sissbruecker July 19, 2024 06:20
@vursen vursen enabled auto-merge (squash) July 23, 2024 09:13
@vaadin-bot
Copy link
Collaborator

TC Format Checker Report - 09:15 - 23 - Jul

BLOCKER There are 1 files with format errors

  • To see a complete report of formatting issues, download the differences file

  • To fix the build, please run mvn formatter:format in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn formatter:format
    

Here is the list of files with format issues in your PR:

vaadin-text-field-flow-parent/vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextField.java

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@vursen vursen merged commit 95dd73b into main Jul 23, 2024
3 of 5 checks passed
@vursen vursen deleted the feat/time-picker/error-messages branch July 23, 2024 09:25
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants