-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add i18n error message support for TimePicker #6365
Conversation
31d5e7b
to
21019e4
Compare
21019e4
to
3dfa921
Compare
...t/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java
Outdated
Show resolved
Hide resolved
During our internal discussion, we discovered a way to keep error messages that are set with |
TC Format Checker Report - 09:15 - 23 - Jul
Here is the list of files with format issues in your PR:
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
Description
The PR introduces TimePickerI18n with methods for setting error messages and updates the TimePicker's validation logic to show these error messages when validation fails.
Note
It's still possible to use the
setErrorMessage
method to configure a single static error message. This error message will be displayed for all constraints and will take priority over any i18n error messages that are also set. However, when more than one error message is needed, i18n should be used or manual validation mode should be enabled.Part of #4618
Type of change