Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ValidationUtil): add methods accepting error message, deprecate old ones #6322

Merged
merged 10 commits into from
Jun 4, 2024
Merged

refactor(ValidationUtil): add methods accepting error message, deprecate old ones #6322

merged 10 commits into from
Jun 4, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented May 24, 2024 •
edited
Loading

Description

  • Added new methods validateRequiredConstraint, validateMinConstraint and validateMaxConstraint to ValidationUtil. They accept a string error message to return in the ValidationResult when the check fails.
  • Deprecated the previous methods without an error message in favor of the new ones.

Part of #4618

Type of change

  • Refactor

@vursen vursen marked this pull request as ready for review May 27, 2024 06:21
@vursen vursen changed the title refactor: add error message overloads to ValidationUtil, deprecate old ones refactor: add methods accepting error message to ValidationUtil, deprecate old ones May 27, 2024
@vursen vursen changed the title refactor: add methods accepting error message to ValidationUtil, deprecate old ones refactor: add methods accepting error message, deprecate old ones May 27, 2024
@vursen vursen changed the title refactor: add methods accepting error message, deprecate old ones refactor: add ValidationUtil methods with error message, deprecate old ones May 27, 2024
@vursen vursen requested review from yuriy-fix, tomivirkki and DiegoCardoso and removed request for tomivirkki May 27, 2024 12:58
yuriy-fix
yuriy-fix reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Consider updating the usage of ValidationUtil.checkRequired in other components as well, such as Checkbox, ComboBox, RadioButtonGroup, Select, etc.

@vursen vursen force-pushed the refactor/add-error-message-overload-to-validation-utils branch from b73fe2f to cc17130 Compare June 3, 2024 09:38
@vursen
Copy link
Contributor Author

vursen commented Jun 3, 2024

Nit: Consider updating the usage of ValidationUtil.checkRequired in other components as well, such as Checkbox, ComboBox, RadioButtonGroup, Select, etc.

Updated.

@vursen vursen mentioned this pull request Jun 3, 2024
Merged
1 task
@vursen vursen enabled auto-merge (squash) June 4, 2024 07:23
@vursen vursen changed the title refactor: add ValidationUtil methods with error message, deprecate old ones refactor: add ValidationUtil methods accepting error message, deprecate old ones Jun 4, 2024
@vursen vursen changed the title refactor: add ValidationUtil methods accepting error message, deprecate old ones refactor(ValidationUtil): add methods accepting error message, deprecate old ones Jun 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen vursen merged commit 52e1270 into main Jun 4, 2024
5 checks passed
@vursen vursen deleted the refactor/add-error-message-overload-to-validation-utils branch June 4, 2024 09:34
@vursen vursen mentioned this pull request Jun 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

@yuriy-fix yuriy-fix yuriy-fix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vursen @DiegoCardoso @yuriy-fix