rewrite ITs to unit tests

vaadin · Jan 27, 2025 · 5fa0a04 · 5fa0a04
1 parent 4498255
commit 5fa0a04
Show file tree

Hide file tree

Showing 5 changed files with 211 additions and 169 deletions.
diff --git a/...ow-integration-tests/src/main/java/com/vaadin/flow/component/button/tests/ButtonView.java b/...ow-integration-tests/src/main/java/com/vaadin/flow/component/button/tests/ButtonView.java
@@ -47,6 +47,7 @@ public ButtonView() {
         createImageButtonWithAutofocus();
         createImageButtonWithAccessibleLabel();
         createButtonsWithTabIndex();
+        createDisabledButton();
         createButtonWithDisableOnClick();
         createButtonWithDisableOnClickThatEnablesInSameRoundTrip();
         createButtonWithDisableOnClickThatIsHidden();
@@ -127,6 +128,17 @@ private void createButtonsWithTabIndex() {
         button3.setId("button-tabindex-3");
     }
 
+    private void createDisabledButton() {
+        Button button = new Button("Disabled");
+        button.setEnabled(false);
+
+        addCard("Disabled button", button);
+        button.addClickListener(evt -> message.setText("Button "
+                + evt.getSource().getText()
+                + " was clicked, but the button is disabled and this shouldn't happen!"));
+        button.setId("disabled-button");
+    }
+
     private void addVariantsFeature() {
         Button button = new Button("Button");
         button.setId("button-theme-variants");

diff --git a/...ration-tests/src/main/java/com/vaadin/flow/component/button/tests/DisabledButtonPage.java b/...ration-tests/src/main/java/com/vaadin/flow/component/button/tests/DisabledButtonPage.java
diff --git a/...flow-integration-tests/src/test/java/com/vaadin/flow/component/button/tests/ButtonIT.java b/...flow-integration-tests/src/test/java/com/vaadin/flow/component/button/tests/ButtonIT.java
@@ -197,6 +197,28 @@ public void clickOnTabIndexButtons_textIsDisplayed() {
         waitUntilMessageIsChangedForClickedButton("1");
     }
 
+    @Test
+    public void clickOnDisabledButton_nothingIsDisplayed() {
+        WebElement button = layout.findElement(By.id("disabled-button"));
+        Assert.assertTrue("The button should contain the 'disabled' attribute",
+                button.getAttribute("disabled").equals("")
+                        || button.getAttribute("disabled").equals("true"));
+
+        // valo theme adds the pointer-events: none CSS property, which makes
+        // the button unclickable by selenium.
+        Assert.assertEquals("none", button.getCssValue("pointer-events"));
+
+        WebElement message = layout.findElement(By.id("buttonMessage"));
+        Assert.assertEquals("", message.getText());
+
+        // Remove disabled Attribute and click again from client side, click
+        // message should not been shown in the dom
+        executeScript("arguments[0].removeAttribute(\"disabled\");"
+                + "arguments[0].click();", button);
+        message = layout.findElement(By.id("buttonMessage"));
+        Assert.assertEquals("", message.getText());
+    }
+
     @Test
     public void clickDisableOnClickButton_newClickNotRegistered() {
         WebElement button = layout

diff --git a/...egration-tests/src/test/java/com/vaadin/flow/component/button/tests/DisabledButtonIT.java b/...egration-tests/src/test/java/com/vaadin/flow/component/button/tests/DisabledButtonIT.java