Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique key for resources #105

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Use unique key for resources #105

merged 1 commit into from
Sep 24, 2019

Conversation

anasmi
Copy link
Contributor

@anasmi anasmi commented Sep 24, 2019 •
edited
Loading

  • Use hash of a resource as key.
  • Update demo

Enhances #104

This change is Reviewable

ZheSun88
ZheSun88 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ZheSun88 ZheSun88 merged commit d698bca into vaadin:master Sep 24, 2019
@ZheSun88 ZheSun88 added this to the 3.0.2 milestone Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@anasmi @ZheSun88