Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing HasEnabled implementation to HighchartsWidget.java #600

Merged
merged 6 commits into from
Nov 6, 2020
Merged

Add missing HasEnabled implementation to HighchartsWidget.java #600

merged 6 commits into from
Nov 6, 2020

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Oct 16, 2020 •
edited by Artur-
Loading

  • Add missing HasEnabled implementation to HighchartsWidget.java
  • Add missing styles for disabled Charts component

Fixes: #427

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

yuriy-fix
yuriy-fix reviewed Oct 19, 2020
View reviewed changes
Copy link

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @TatuLund , can I kindly ask to add test as well, so we will be able to accept the PR?

@DiegoCardoso DiegoCardoso merged commit 403a0f9 into vaadin:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriy-fix yuriy-fix yuriy-fix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.setEnabled does nothing visually
4 participants
@TatuLund @CLAassistant @yuriy-fix @DiegoCardoso