Use zlib-rs as primary deflate backend #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue we had with the "data\wav\worm_tail_damage.wav" sound file that can't be read with miniz_oxide of libflate. Interestingly, the trait BufRead is implemented for `&[u8]` and the internals of `read_to_end()` essentially handles the writing into uninitialized memory of the Vector extremely efficiently then.
hasenbanck
force-pushed
the
update_deflate
branch
from
60d8460 to
a5a7175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue we had with the "data\wav\worm_tail_damage.wav" sound file that can't be read with miniz_oxide of libflate.
Interestingly, the trait BufRead is implemented for
&[u8]and the internals ofread_to_end()essentially handles the writing into uninitialized memory of the Vector extremely efficiently then.