Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the version file is correct #1023

Merged
merged 8 commits into from
Feb 28, 2025
Merged

Conversation

umbertoDifa
Copy link
Collaborator

No description provided.

@Copilot Copilot bot review requested due to automatic review settings February 28, 2025 14:26
@umbertoDifa umbertoDifa merged commit f3e7a0a into master Feb 28, 2025
7 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR ensures that the correct file is used for version updates. The main changes include updating the file path for the version string from darwin/init.py to darwin/version/init.py and conditionally executing the branch creation and commit steps when TEST_MODE is true.

Reviewed Changes

File Description
.github/workflows/version_bump.yml Updates the version file location and adds a conditional check for test mode.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/version_bump.yml:92

  • Ensure that the new file path 'darwin/version/init.py' exists and is the intended location for updating the version string, and update any additional documentation or references accordingly.
awk -v new_version="$TEST_VERSION" '/^__version__ = / {$0 = "__version__ = \"" new_version "\""} 1' darwin/version/__init__.py > darwin/version/__init__.tmp && mv darwin/version/__init__.tmp darwin/version/__init__.py

.github/workflows/version_bump.yml:112

  • Verify that the 'if:' condition is correctly indented and positioned to apply to the 'Create branch and commit changes' step as intended in the GitHub Actions workflow.
if: ${{ env.TEST_MODE == 'true' }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants