Fix errors on tags page #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luceos or @davwheat would you be able to merge this and tag a new version? The sooner, the better, as we (@glowingblue) have this error in production currently. |
davwheat
reviewed
Mar 2, 2023
davwheat
approved these changes
Mar 2, 2023
|
Thanks for merging @davwheat ! Could you also tag a new version, please? |
|
Ah it's tagged now, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tags page UI is extended and customized, the current code that tries to manipulate the virtual DOM doing thing like
might break because the indexes of children have changed.
This PR adds a safer and more flexible way of manipulating the virtual DOM using a recursive helper function that searches for a node with a certain class name.
Tested locally on the instance that was failing and everything seems to be fine.
While making this PR I realized there was strange (seemingly copy-pasted) comments and code that was referring to "knowledge base" even though this is the blog extension and not the knowledge base extension.