Change Blog post title from h3 to h1 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
approved these changes
May 13, 2023
|
Requirement updated to |
davwheat
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recent discussion and changes about heading tags (flarum/framework#3724), I thought it would be a good idea to change the blog post title to h1, now that 1.7 will no longer use h1 in the logo.
I haven't found any other references to the title, but it would be nice to double check, also taking this into account, I would like to know if it would be necessary to add the
^1.7.0requirement, because otherwise in previous versions there will be two h1 per page and I'm not sure if that is recommended.