Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cublas][curand][cusolver] Fix OpenCL include dir hint #597

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

npmiller
Copy link
Contributor

In recent versions of DPC++ the CL headers go in include instead of include/sycl. So this patch fixes finding the OpenCL headers. Keep the hints for the previous path to still support older version.

In recent versions of DPC++ the CL headers go in `include` instead of
`include/sycl`. So this patch fixes finding the OpenCL headers. Keep the
hints for the previous path to still support older version.
@npmiller npmiller requested a review from a team as a code owner October 18, 2024 14:06
@Rbiessy
Copy link
Contributor

Rbiessy commented Oct 18, 2024

Won't FindcuSOLVER.cmake and FindcuRAND.cmake run into the same issue?

@npmiller
Copy link
Contributor Author

Maybe, we just ran into this for cuBLAS, I'll see if the other ones need it too

@Rbiessy Rbiessy changed the title [cublas] Fix OpenCL include dir hint for cuBLAS [cublas][curand][cusolver] Fix OpenCL include dir hint Oct 18, 2024
Copy link
Contributor

@sknepper sknepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @npmiller !

@Rbiessy Rbiessy merged commit 1462c0b into uxlfoundation:develop Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants