[BLAS][portBLAS] Add try/catch for portblas runtime exception & minor fix #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjabird
reviewed
Jul 4, 2024
Signed-off-by: nscipione <[email protected]>
Add missing double support checks in omatcopy2 tests.
Change exception catch to the portBLAS one required.
Rbiessy
approved these changes
Jul 15, 2024
hjabird
approved these changes
Jul 17, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
… fix (uxlfoundation#525) Signed-off-by: nscipione <[email protected]> * Catch PortBLAS's unsupported exceptions and rethrow as mkl::unimplemented. * Add missing checks for the device having double support in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds exception handling to portBLAS backend implementation. This would allow us to handle corner cases in portBLAS.
It also adds a minor fix to
omatcopy2tests adding check if double precision is supported by the device before running tests.Checklist
All Submissions
Do all unit tests pass locally?
intel_arc_log.txt
Have you formatted the code using clang-format?