Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DFT][CMake] Fix inclusion of public include directories when linking against a DFT backend library #523

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[DFT][CMake] Fix inclusion of public include directories when linking against a DFT backend library #523

merged 2 commits into from
Jul 17, 2024

Conversation

hjabird
Copy link
Contributor

@hjabird hjabird commented Jun 28, 2024 •
edited
Loading

Description

This PR ensures that linking against backend such as target_link_library(myApp PRIVATE onemkl_dft_cufft correctly includes the oneMKL public include directories.

Fixes #442

Checklist

All Submissions

Bug fixes

  • [ish] Have you added relevant regression tests?
    • The compile-time DFT example has been modified to depend on the described functionality.
  • Have you included information on how to reproduce the issue (either in a
    GitHub issue or in this PR)?

@hjabird hjabird changed the title Hjab/static backend include fix [DFT][CMake] Fix inclusion of public include directories when linking against a DFT backend library Jun 28, 2024
@hjabird hjabird marked this pull request as ready for review July 2, 2024 10:15
@hjabird hjabird force-pushed the hjab/static_backend_include_fix branch from 2ee56bd to 8926288 Compare July 2, 2024 10:30
@hjabird
Copy link
Contributor Author

hjabird commented Jul 3, 2024

This affects only the build, so pinging @vmalia.

@hjabird
Copy link
Contributor Author

hjabird commented Jul 3, 2024

I'm told I pinged the wrong person - sorry vmalia! @mkrainiuk

@Rbiessy Rbiessy requested a review from a team July 11, 2024 10:29
mkrainiuk
mkrainiuk approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mkrainiuk mkrainiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! I have one minor question.

examples/dft/compile_time_dispatching/CMakeLists.txt Show resolved Hide resolved
@hjabird hjabird merged commit 30aedaf into uxlfoundation:develop Jul 17, 2024
6 checks passed
@hjabird hjabird deleted the hjab/static_backend_include_fix branch July 17, 2024 10:17
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
@hjabird @normallytangent
[DFT][CMake] Fix inclusion of public include directories when linking…
032ae69 
… against a DFT backend library (uxlfoundation#523)

* Using the DFT backend targets should include the public include directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkrainiuk mkrainiuk mkrainiuk approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CMake][DFT] target_link_library(myTarget PRIVATE MKL::onemkl_dft_XXX) does not add includes
3 participants
@hjabird @mkrainiuk @Rbiessy