[DFT] Improve support for different ROCm versions #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the include path to allow compiling rocFFT backend with ROCm>=6.0. Set the minimum required rocfft version in CMake to match with the README version.
lhuot
reviewed
Apr 9, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attached is the test log on AMD using the Codeplay plugin. Currently it supports the ROCm version 5.4.3.
dft_rocm_tests.txt
I have verified that this builds with ROCm 6.0.0 but this can't be run using the Codeplay plugins yet.
Checklist
All Submissions
Bug fixes
GitHub issue or in this PR)?