-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] skip DP tests on devices without DP support #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Would it be possible to add a macro for the check and use it everywhere? It would make it easier if we need to update it later.
This is a good idea, I will update the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Looks good to me.
The DFT tests can also use double precision, should we add the same kind of checks there in this PR? Last time I checked the CI is running very few DFT tests for the GPU device but I don't know why. |
As I see DFT already has the check for DP support on the device during commit stage https://github.com/oneapi-src/oneMKL/blob/develop/tests/unit_tests/dft/source/descriptor_tests.cpp#L599-L601 |
Indeed, I missed that, thanks! |
Co-authored-by: Romain Biessy <[email protected]>
Co-authored-by: Romain Biessy <[email protected]>
Description
PR adds double precision support check to unit tests for skipping double precision tests on devices that do not support it.
I've tested the changes on Intel Arc A770, all double precision tests are skipped as expected, all other tests are passed except for
GemmBatchUsm
for half precision (not related to the changes).Checklist
All Submissions