Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] skip DP tests on devices without DP support #395

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

mkrainiuk
Copy link
Contributor

@mkrainiuk mkrainiuk commented Oct 16, 2023

Description

PR adds double precision support check to unit tests for skipping double precision tests on devices that do not support it.

I've tested the changes on Intel Arc A770, all double precision tests are skipped as expected, all other tests are passed except for GemmBatchUsm for half precision (not related to the changes).

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

Copy link
Contributor

@mmeterel mmeterel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Would it be possible to add a macro for the check and use it everywhere? It would make it easier if we need to update it later.

@mkrainiuk
Copy link
Contributor Author

Thanks for the PR. Would it be possible to add a macro for the check and use it everywhere? It would make it easier if we need to update it later.

This is a good idea, I will update the tests.

Copy link
Contributor

@mmeterel mmeterel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks good to me.

@Rbiessy
Copy link
Contributor

Rbiessy commented Oct 17, 2023

The DFT tests can also use double precision, should we add the same kind of checks there in this PR? Last time I checked the CI is running very few DFT tests for the GPU device but I don't know why.

@mkrainiuk
Copy link
Contributor Author

mkrainiuk commented Oct 17, 2023

The DFT tests can also use double precision, should we add the same kind of checks there in this PR? Last time I checked the CI is running very few DFT tests for the GPU device but I don't know why.

As I see DFT already has the check for DP support on the device during commit stage https://github.com/oneapi-src/oneMKL/blob/develop/tests/unit_tests/dft/source/descriptor_tests.cpp#L599-L601
Let me know if I missed something for DFT.

@Rbiessy
Copy link
Contributor

Rbiessy commented Oct 18, 2023

As I see DFT already has the check for DP support on the device during commit stage https://github.com/oneapi-src/oneMKL/blob/develop/tests/unit_tests/dft/source/descriptor_tests.cpp#L599-L601 Let me know if I missed something for DFT.

Indeed, I missed that, thanks!
I'll make sure to add this to #374 once this is merged.

@mkrainiuk mkrainiuk merged commit 22bfc7b into uxlfoundation:develop Oct 18, 2023
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants