[LAPACK][CUSOLVER] Add getri batch funcs #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clarification: I have not added the group USM functions since I don't want to give the user the impression that the group getri is calling some |
|
Have all comments been addressed? |
Alexander-Kleymenov
approved these changes
Jan 27, 2023
|
Can this get merged? |
|
Can we get this merged. |
sknepper
approved these changes
Jun 2, 2023
mkrainiuk
approved these changes
Jun 2, 2023
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
* Add getri batch funcs * Responding to comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds getri batch funcs as well as getri (which calls getri_batch). The GetriBatch funcs are in CUBLAS, not CUSOLVER so some CMake changes were necessary.
Fixes # (GitHub issue)
#229
Clang-formatted and tests passing locally.
I have not included the group funcs in this PR. Should I do so?