Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLAS] add interfaces to some BLAS-like extensions in oneMKL #202

Closed
wants to merge 35 commits into from
Closed

[BLAS] add interfaces to some BLAS-like extensions in oneMKL #202

wants to merge 35 commits into from

Conversation

andrewtbarker
Copy link
Contributor

Description

This PR adds interfaces to imatcopy_batch_strided() and omatcopy_batch_strided() from oneMKL. Stubs and "not implemented" exceptions are added for cublas, rocblas and netlib backends.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log ( cuda-test.txt and mklgpu-test.txt )
    .
  • Have you formatted the code using clang-format? (all the new code is clang-format; some of the files need more formatting, but I am leaving as is for now to make review easier, format of all the files can be done before merge)

New interfaces

  • Have you provided motivation for adding a new feature as part of RFC and
    it was accepted? # (RFC)
  • What version of oneAPI spec the interface is targeted?
  • Complete New features checklist

@andrewtbarker
[BLAS] add imatcopy_batch omatcopy_batch to mklgpu backend
2fddb58
@andrewtbarker
[BLAS] add some stubs for functions / declarations I need to add
bb9ddb5
@andrewtbarker
[BLAS] {i,o}matcopy_batch in mklcpu_batch.cxx, mklgpu_batch.cxx
006cda9
@andrewtbarker
[BLAS] {i,o}matcopy_batch in mklgpu_common.hpp
86225ef
@andrewtbarker
[BLAS] add strided imatcopy_batch, omatcopy_batch to blas_ct.hxx
6b1cec8
@andrewtbarker
[BLAS] add {i,o}matcopy_batch_strided to include/oneapi/mkl/blas.hxx
3969395
@andrewtbarker
[BLAS] fix some issues in blas_ct.hxx (std::int64_t, auto done)
453e9bc
@andrewtbarker
[BLAS] {i,o}matcopy_batch in blas_ct_backends.hxx
3c15767
@andrewtbarker
[BLAS] {i,o}matcopy_batch (strided) in onemkl_blas_backends.hxx
93003f6
@andrewtbarker
[BLAS] {i,o}matcopy_batch strided in blas_loader.hxx
4d06434
@andrewtbarker
[BLAS] netlib_batch.cxx backend unimplemented for {i,o}matcopy_batch …
dacbb19 
…strided
@andrewtbarker
[BLAS] some boilerplate for (unimplemented) netlib {i,o}matcopy_batch
0a147cb
@andrewtbarker
[BLAS] rocblas backend boilerplate for {i,o}matcopy_batch strided
3a03f38
@andrewtbarker
[BLAS] cublas boilerplate for {i,o}matcopy_batch stirded
f7bf603
@andrewtbarker
[BLAS] more cublas/rocblas boilerplate for backend {i,o}matcopy_batch…
7e7854e 
… (strided)
@andrewtbarker
[BLAS] mklgpu/blas_ct.hxx precondition/postcondition etc.
28066d5
@andrewtbarker
[BLAS] non-existent error checking for {i,o}matcopy_batch in predicat…
df592fd 
…es.hxx
@andrewtbarker
[BLAS] {i,o}matcopy_batch (strided) not implemented exception in rocb…
f814d2c 
…las backend
@andrewtbarker
[BLAS] correct some datatypes in mkl{c,g}pu_batch.cxx
2a93277
@andrewtbarker
[BLAS] {i,o}matcopy_batch (strided) in cublas_batch.cpp (not implemen…
aac3645 
…ted exception)
@andrewtbarker
[BLAS] rocblas, cublas wrapper function tables
af53358
@andrewtbarker
[BLAS] add new functions to src/blas/function_table.hpp
1ac8e3f
@andrewtbarker
[BLAS] {i,o}matcopy_batch (strided) in blas_loader.cpp
7ec14e9 
Last non-test file in the grep list
@andrewtbarker
[BLAS] correct precondition/postcondition function names in predicate…
8c6b283 
…s.hxx
@andrewtbarker
[BLAS] mklcpu_batch.cxx omatcopy should call omatcopy
bc5c4d0
@andrewtbarker
[BLAS] corrections from compilation: order of function table, no grou…
ffd3a64 
…p batch
@andrewtbarker
[BLAS] more mklcpu_batch.cxx backend fixes, complex numbers, argument…
4cc44d5 
…s, etc.
@andrewtbarker
[BLAS] correct function signature for mkl_x{i,o}matcopy_sycl
f17d461
@andrewtbarker
[BLAS] missing entries in function table for cublas and rocblas backends
3bf721b
@andrewtbarker
[BLAS] minor clang-format
b15da1e
@mmeterel
Copy link
Contributor

mmeterel commented Jun 8, 2022

This PR is gated by adding the new APIs into oneMKL spec first.

@andrewtbarker andrewtbarker mentioned this pull request Jun 15, 2022
Closed
@andrewtbarker
Copy link
Contributor Author

Replaced by #227.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtbarker @mmeterel