-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLAS, cuBLAS backend, hipSYCL] Add official hipsycl cuBLAS support #166
Conversation
@sbalint98 As you are aware, there were several changes since the time this PR is opened. Could you please rebase and check if the tests are all good? Also, I think, we can enable cuRAND backend with hipSYCL with this PR as well. What do you think? Could you please let me know when everything is ready? |
Hi @mmeterel thank you for reminding me. I'll have a look and prepare this PR until Monday. I'll let you know if it is ready for review |
7e9cd2d
to
5c11023
Compare
Sorry for the delay. I have rebased the branch and updated the readme. All tests are passing on my sid |
@sbalint98 Thanks. Do you plan to add cuRAND support in this PR as well? |
@nilsfriess and @normallytangent are working on the cuRAND support. I believe for them it might be easier to open a new PR. Would this be acceptable for you? |
Sure, that works if it will be easier on your side. |
@sbalint98 |
@mkrainiuk Could you please take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Changes look good to me. I have one minor comment.
CUDA_LIBRARIES | ||
CUDA_CUDART_LIBRARY | ||
) | ||
set_target_properties(ONEMKL::cuBLAS::cuBLAS PROPERTIES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reasons we cannot use one set_target_properties
? I see the only difference: OPENCL_INCLUDE_DIR
that can be added with inline check, something like "$<$BOOL:${USE_ADD_SYCL_TO_TARGET_INTEGRATION}: ${OPENCL_INCLUDE_DIR}>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure...but i also see differences between CUDA_CUDART_LIBRARY vs CUDA_CUDA_LIBRARY
As discussed under PR #144 hipSYCL rocBLAS support comes with automatic support for cuBLAS as well. This PR adds this information to the README.
Furthermore, this PR differentiates the FindcuBLAS.cmake file between hipSYCL and Intel LLVM. In the case of hipSYCL, there is no need to have the
OPENCL_PATH
set. Moreover, theCUDA_CUDA_LIBRARY
environment variable is also not strictly necessary since finding the libcuda.so is handled by hipSYCL.onemkl-cuda-hipsycl-test.txt