Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add assignment operators for Input and Parameter classes of solvers #3049

Merged

Conversation

david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Jan 22, 2025

Description

Should solve issues with static analyzers pointing out that there are copy constructors without assignment operators for many of the Input and Parameter class used in optimization routines and which are exported.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

Performance

Not applicable.

@david-cortes-intel david-cortes-intel changed the title MAINT: Add assignment operator for AdaGrad Input class MAINT: Add assignment operators for Input and Parameter classes of solvers Jan 22, 2025
@david-cortes-intel david-cortes-intel marked this pull request as draft January 22, 2025 09:33
@david-cortes-intel
Copy link
Contributor Author

Changed the scope of the PR to modify several classes instead of just one.

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel david-cortes-intel marked this pull request as ready for review January 22, 2025 12:55
@david-cortes-intel david-cortes-intel merged commit d43c4ab into uxlfoundation:main Jan 23, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants