-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Add assignment operators for Input and Parameter classes of solvers #3049
Merged
david-cortes-intel
merged 18 commits into
uxlfoundation:main
from
david-cortes-intel:copy_const_adagrad
Jan 23, 2025
Merged
MAINT: Add assignment operators for Input and Parameter classes of solvers #3049
david-cortes-intel
merged 18 commits into
uxlfoundation:main
from
david-cortes-intel:copy_const_adagrad
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cortes-intel
requested review from
Alexsandruss,
samir-nasibli and
Alexandr-Solovev
as code owners
January 22, 2025 08:47
Alexandr-Solovev
approved these changes
Jan 22, 2025
david-cortes-intel
changed the title
MAINT: Add assignment operator for AdaGrad Input class
MAINT: Add assignment operators for Input and Parameter classes of solvers
Jan 22, 2025
Changed the scope of the PR to modify several classes instead of just one. |
/intelci: run |
Alexsandruss
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should solve issues with static analyzers pointing out that there are copy constructors without assignment operators for many of the
Input
andParameter
class used in optimization routines and which are exported.PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.