Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: enabling oneDPL and sort primitive refactoring #3046

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feature: enabling oneDPL and sort primitive refactoring #3046

wants to merge 15 commits into from

Conversation

Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Jan 16, 2025 •
edited
Loading

Description:

Feature: enabling oneDPL and sort primitive refactoring

Summary:

This PR introduces oneDPL enabling and radix sort replacement.

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@david-cortes-intel
Copy link
Contributor

Before merging, please remember to add this new dependency to the installation instructions in INSTALL.md, along with instructions for setting necessary env. variables when using conda:
https://github.com/uxlfoundation/oneDAL/blob/main/INSTALL.md

@Alexandr-Solovev Alexandr-Solovev added dpc++ Issue/PR related to DPC++ functionality dependencies Pull requests that update a dependency file labels Jan 22, 2025
@Alexandr-Solovev Alexandr-Solovev changed the title init adding dpl feature: enabling oneDPL and sorting primitive refactoring Jan 22, 2025
@Alexandr-Solovev Alexandr-Solovev marked this pull request as ready for review January 22, 2025 20:28
@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev Alexandr-Solovev changed the title feature: enabling oneDPL and sorting primitive refactoring feature: enabling oneDPL and sort primitive refactoring Jan 22, 2025
napetrov
napetrov reviewed Jan 22, 2025
View reviewed changes
.ci/pipeline/ci.yml Outdated Show resolved Hide resolved
@Alexandr-Solovev
Copy link
Contributor Author

/azp run CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

david-cortes-intel
david-cortes-intel reviewed Jan 23, 2025
View reviewed changes
INSTALL.md
@@ -23,6 +23,7 @@ Required Software:
* BLAS and LAPACK libraries - both provided by oneMKL
* Python version 3.9 or higher
* TBB library (repository contains script to download it)
* oneDPL library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alexandr-Solovev Please remember to update also the conda instructions that appear towards the end of this file.

The package name for conda should be onedpl-devel, and it needs to update the list of environment variables to add DPL_ROOT.

@icfaust
Copy link
Contributor

icfaust commented Jan 27, 2025

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

@icfaust currently it works only with custom ci branch:
http://intel-ci.intel.com/efd9a7d1-b105-f1dd-a5e6-a4bf010d0e2d

david-cortes-intel
david-cortes-intel reviewed Jan 27, 2025
View reviewed changes
INSTALL.md
@@ -113,9 +114,25 @@ is available as an alternative to the manual setup.

./dev/download_tbb.sh

6. Download and install Python (version 3.9 or higher).
6. Set up Intel(R) Threading Building Blocks (Intel(R) TBB):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Set up Intel(R) Threading Building Blocks (Intel(R) TBB):
6. Set up Intel(R) OneDPL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cortes-intel david-cortes-intel david-cortes-intel left review comments

@napetrov napetrov napetrov left review comments

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@samir-nasibli samir-nasibli Awaiting requested review from samir-nasibli samir-nasibli is a code owner

@homksei homksei Awaiting requested review from homksei homksei is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser is a code owner

@Vika-F Vika-F Awaiting requested review from Vika-F Vika-F is a code owner

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova maria-Petrova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file dpc++ Issue/PR related to DPC++ functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexandr-Solovev @david-cortes-intel @icfaust @napetrov